Re: Cc'ing the Git maintainer on GitGitGadget contributions, was Re: [PATCH 0/1] add--interactive: skip index refresh in reset patch mode

From: Taylor Blau <me@ttaylorr.com>
Date: Jan 8, 2021, 20:08 UTC
Message-ID: <X/i7zvgMJHfOmyZG@nand.local>
In-Reply-To: <nycvar.QRO.7.76.6.2101081534380.2213@tvgsbejvaqbjf.bet>

On Fri, Jan 08, 2021 at 03:56:20PM +0100, Johannes Schindelin wrote:

Show 10 quoted lines

> Hi Junio,
>
> On Thu, 7 Jan 2021, Junio C Hamano wrote:
>
> > We may not be able to automate the thinking part to decide when
> > submitter may want to get help, but an automation can help by giving
> > the submitter cues and clues when to ask for help and from whom.
>
> I fear that we're striking the balance on the side of expecting too much
> knowledge about project-specific lore from contributors.

I think that this could be reasonably addressed. When someone opens a PR (but before the hit /submit), GGG could say:

    Your change touches these files, and so suggested reviewers include
    X, Y, Z. When you believe your submission is in its last round,
    please also include the maintainer, M.

Show 7 quoted lines

> We already have a ticket suggesting to add reviewers:
> https://github.com/gitgitgadget/gitgitgadget/issues/219
>
> With this suggestion, too, we could go and extend that wall of text even
> further and expect contributors to just know what they are supposed to do.
> But I don't see how that would make this process more inviting to new
> contributors.

Yeah, I agree that adding this as a separate step does not make sense, since it's hard to discover such things (especially by individuals who merely want to send a single contribution to the project). Having this happen automatically upon creating a PR would make more sense to me.

Thanks, Taylor