Re: [PATCH v2 00/22] pickaxe: test and refactoring for follow-up changes

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 16, 2021, 22:23 UTC
Message-ID: <xmqq8s7nps7x.fsf@gitster.c.googlers.com>
In-Reply-To: <20210216115801.4773-1-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

Show 8 quoted lines

> This is a smaller v2 of the series to remove the kwset backend and
> make pickaxe use PCRE v2[1].
>
> That's not being done here yet. These are mostly small
> refactoring/test fixes. The most significant work is a new xdiff
> interface at the end of the series.
>
> It's based on next where some preparatory work already landed[2].

Do you really mean <20210204210556.25242-1-avarab@gmail.com>?

  grep/pcre2: drop needless assignment + assert() on opt->pcre2
  grep/pcre2: drop needless assignment to NULL
  grep/pcre2: correct reference to grep_init() in comment
  grep/pcre2: prepare to add debugging to pcre2_malloc()
  grep/pcre2: add GREP_PCRE2_DEBUG_MALLOC debug mode
  grep/pcre2: use compile-time PCREv2 version test
  grep/pcre2: use pcre2_maketables_free() function
  grep/pcre2: actually make pcre2 use custom allocator
  grep/pcre2: move back to thread-only PCREv2 structures
  grep/pcre2: move definitions of pcre2_{malloc,free}

I do not think we have that many patches whose title begin with grep/pcre2 in 'next'.

In any case, I'd rather not to see things done directly on 'next'; targetting a selected few topics merged on top of 'master' would not be bad, though.

Thanks.