Re: [PATCH v2 04/22] test-lib functions: add --printf option to test_commit

> Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:
>
>>  test_expect_success 'can parse blob ending with CR' '
>> -	printf "[some]key = value\\r" >config &&
>> -	git add config &&
>> -	git commit -m CR &&
>> +	test_commit --printf CR config "[some]key = value\\r" &&
>
> OK, the first arg becomes the commit title, and the second one is
> used for the filename, and the next arg is the string given to
> printf, I guess.
>
>>  test_expect_success 'rerere forget (binary)' '
>>  	git checkout -f side &&
>> -	printf "a\0c" >binary &&
>> -	git commit -a -m binary &&
>> +	test_commit binary binary "a\0c" &&
>
> This lacks --printf.  Are we breaking the test but "test-must-fail"
> is hiding the breakage here?