Re: [PATCH v2 2/6] tree.c API: move read_tree() into builtin/ls-files.c

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 12, 2021, 21:41 UTC
Message-ID: <xmqq8s6s6od9.fsf@gitster.g>
In-Reply-To: <20210308022138.28166-3-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> Now builtin/ls-files.c is the last user of this code, let's move all
> the relevant code there. This allows for subsequent simplification of
> it, and an eventual move to read_tree_recursive().

There is a comment in cache.h that has long been a tad stale but not wrong. This finally makes it incorrect.

#define ADD_CACHE_JUST_APPEND 8		/* Append only; tree.c::read_tree() */

It would be sufficient to remove the mention of tree.c::read_tree(). It does use this bit, but there are a few others, and there is not much point in singling out the oldest user the bit was invented for.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.