Re: [PATCH v5 06/18] diff tests: test that "mode" is passed when sorting

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 31, 2021, 23:07 UTC
Message-ID: <xmqq5z166hxi.fsf@gitster.g>
In-Reply-To: <patch-06.19-0be013e47c4-20210331T190531Z-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> Piggy-back on the recently added fsck tests for mode comparisons in
> mktree and assert that diff-tree also does the right thing in this
> implausible scenario.

The same comment applies. Just testing the order of "foo" (blob), "foo." (blob), "foo/" (tree), and "foo0" (blob) in two comparisons would be a more realistic test that has more practical value.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.