Re: [PATCH 4/5] config.c: add a "tristate" helper
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 10, 2021, 01:43 UTC
- Message-ID
- <xmqq8s5qlxr9.fsf@gitster.g>
- In-Reply-To
- <YHD+BMo35krbH9rx@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 6 quoted lines
> So a function like: > > int git_parse_tristate(const char *value, int *out); > > which returned success/error via its return value, and put the value > into "out" would feel pretty natural to me.
Yeah, with s/tristate/bool-or-auto/, and if we do this throughout the types, that would be ideal. FWIW git_parse_ulong() and friends for sized numerics already follow that pattern, but helpers for boolean like git_parse_maybe_bool() don't, which is unfortunate.