From: Junio C Hamano Date: Sat, 10 Apr 2021 01:43:54 GMT Subject: Re: [PATCH 4/5] config.c: add a "tristate" helper Message-ID: In-Reply-To: Jeff King writes: > So a function like: > > int git_parse_tristate(const char *value, int *out); > > which returned success/error via its return value, and put the value > into "out" would feel pretty natural to me. Yeah, with s/tristate/bool-or-auto/, and if we do this throughout the types, that would be ideal. FWIW git_parse_ulong() and friends for sized numerics already follow that pattern, but helpers for boolean like git_parse_maybe_bool() don't, which is unfortunate.