Re: [PATCH RESEND v2] make: add install-stripped target

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 31, 2021, 17:06 UTC
Message-ID: <xmqq8s0hwnkm.fsf@gitster.g>
In-Reply-To: <20210831013235.388682-1-bagasdotme@gmail.com>

Bagas Sanjaya <bagasdotme@gmail.com> writes:

> Add the target that install Git with stripped executables.
> ...
> +
> +install-stripped: INSTALL_OPTS = -s --strip-program=$(STRIP)

Not everybody's $(INSTALL) supports --strip-program, does it?

FreeBSD seems to lack the option, and instead uses the $STRIPBIN environment variable to specify which program to use.

The manual page for macOS [*] does not mention --strip-program or STRIPBIN.

If the user leaves STRIP as the default (i.e. strip), this target fails, not because the user does not have 'strip', but because the 'install' used by the user does not know the --strip-program option, even though there is no need to use the option in such a case.

Given that, I am not sure if we really want "install-stripped" target. Adding INSTALL_OPTS make variable that defaults to an empty string is a good idea, but we probably can and should stop there.

Then users can do any of the following:

	$ make INSTALL_OPTS=-s install

	$ STRIPBIN=my-strip make INSTALL_OPTS=-s install

depending on their system, which sounds sufficient, and is a vast improvement over the current

	$ make ; make strip ; make install

I would think.

[Reference]

* https://opensource.apple.com/source/file_cmds/file_cmds-321.40.3/install/install.1.auto.html