Re: [PATCH RESEND v2] make: add install-stripped target

From: Bagas Sanjaya <bagasdotme@gmail.com>
Date: Sep 1, 2021, 11:31 UTC
Message-ID: <96e4b388-d924-e5a9-b23f-07cc0007c328@gmail.com>
In-Reply-To: <xmqq8s0hwnkm.fsf@gitster.g>

On 01/09/21 00.06, Junio C Hamano wrote:

Show 16 quoted lines

> Given that, I am not sure if we really want "install-stripped"
> target.  Adding INSTALL_OPTS make variable that defaults to an empty
> string is a good idea, but we probably can and should stop there.
> 
> Then users can do any of the following:
> 
> 	$ make INSTALL_OPTS=-s install
> 
> 	$ STRIPBIN=my-strip make INSTALL_OPTS=-s install
> 
> depending on their system, which sounds sufficient, and is a vast
> improvement over the current
> 
> 	$ make ; make strip ; make install
> 
> I would think.

If we make $(INSTALL_OPTS) applies to both compiled executables and scripts, we have problem that $(INSTALL) -s only works for the former.

-- 
An old man doll... just what I always wanted! - Clara