Re: [PATCH 3/3] config tests: fix harmless but broken "rm -r" cleanup

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 22, 2022, 05:37 UTC
Message-ID: <xmqq8rpp8div.fsf@gitster.g>
In-Reply-To: <xmqq4k0dfxxm.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 14 quoted lines

> Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:
>
>>  test_expect_success 'override global and system config' '
>> -	test_when_finished rm -f "$HOME"/.config/git &&
>> +	test_when_finished "rm -rf \"$HOME\"/.config/git" &&
>
> As this string is evaled, isn't it safer to defer dereferencing the
> environment variable at the runtime by quoting the dollar-sign, too?
>
> I.e.
>
> 	test_when_finished rm -rf \"\$HOME\"/.config/git &&
>
> or something?

It probably would matter if $HOME had a double-quote in it, I think