git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 1/3] tests: add missing double quotes to included library paths

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Jun 30, 2022, 10:18 UTC
Message-ID
<patch-v2-1.3-f4ef137d076-20220630T101646Z-avarab@gmail.com>
In-Reply-To
<cover-v2-0.3-00000000000-20220630T101646Z-avarab@gmail.com>

Fix inclusion errors which would occur if the $TEST_DIRECTORY had $IFS whitespace in it.

See d42bab442d7 (core.fsyncmethod: tests for batch mode, 2022-04-04) and a242c150ebb (vimdiff: integrate layout tests in the unit tests framework ('t' folder), 2022-03-30) for the two relevant commits. Both were first released with v2.37.0-rc0 (and were also part of v2.37.0).

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 t/t3700-add.sh            | 2 +-
 t/t3903-stash.sh          | 2 +-
 t/t7609-mergetool--lib.sh | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/t/t3700-add.sh b/t/t3700-add.sh
index 8979c8a5f03..8689b48589c 100755
--- a/t/t3700-add.sh
+++ b/t/t3700-add.sh
@@ -8,7 +8,7 @@ test_description='Test of git add, including the -- option.'
 TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 
-. $TEST_DIRECTORY/lib-unique-files.sh
+. "$TEST_DIRECTORY"/lib-unique-files.sh
 
 # Test the file mode "$1" of the file "$2" in the index.
 test_mode_in_index () {
diff --git a/t/t3903-stash.sh b/t/t3903-stash.sh
index 20e94881964..2a4c3fd61c0 100755
--- a/t/t3903-stash.sh
+++ b/t/t3903-stash.sh
@@ -9,7 +9,7 @@ GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
 export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
 
 . ./test-lib.sh
-. $TEST_DIRECTORY/lib-unique-files.sh
+. "$TEST_DIRECTORY"/lib-unique-files.sh
 
 test_expect_success 'usage on cmd and subcommand invalid option' '
 	test_expect_code 129 git stash --invalid-option 2>usage &&
diff --git a/t/t7609-mergetool--lib.sh b/t/t7609-mergetool--lib.sh
index d848fe6442b..330d6d603d7 100755
--- a/t/t7609-mergetool--lib.sh
+++ b/t/t7609-mergetool--lib.sh
@@ -7,7 +7,7 @@ Testing basic merge tools options'
 . ./test-lib.sh
 
 test_expect_success 'mergetool --tool=vimdiff creates the expected layout' '
-	. $GIT_BUILD_DIR/mergetools/vimdiff &&
+	. "$GIT_BUILD_DIR"/mergetools/vimdiff &&
 	run_unit_tests
 '
 
-- 
2.37.0.880.gf07d56b18ba
Previous: Ævar Arnfjörð BjarmasonNext: Ævar Arnfjörð Bjarmason
Message 9 of 12 in “tests: fix tests broken if a " " is in the checkout dir's path”
  1. 0/3 tests: fix tests broken if a " " is in the checkout dir's pathÆvar Arnfjörð Bjarmason, Jun 21, 2022
  2. 1/3 tests: add missing double quotes to included library pathsÆvar Arnfjörð Bjarmason, Jun 21, 2022
  3. Junio C HamanoJun 21, 2022
  4. 2/3 test-lib.sh: fix prepend_var() quoting issueÆvar Arnfjörð Bjarmason, Jun 21, 2022
  5. 3/3 config tests: fix harmless but broken "rm -r" cleanupÆvar Arnfjörð Bjarmason, Jun 21, 2022
  6. Junio C HamanoJun 21, 2022
  7. Junio C HamanoJun 22, 2022
  8. 0/3 tests: fix tests broken if a " " is in the checkout dir's pathÆvar Arnfjörð Bjarmason, Jun 30, 2022
  9. 1/3 tests: add missing double quotes to included library pathsÆvar Arnfjörð Bjarmason, Jun 30, 2022
  10. 2/3 test-lib.sh: fix prepend_var() quoting issueÆvar Arnfjörð Bjarmason, Jun 30, 2022
  11. 3/3 config tests: fix harmless but broken "rm -r" cleanupÆvar Arnfjörð Bjarmason, Jun 30, 2022
  12. Junio C HamanoJun 30, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.