Re: [PATCH v3 3/5] clone: add --bundle-uri option

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 22, 2022, 21:24 UTC
Message-ID: <xmqq8rngas5q.fsf@gitster.g>
In-Reply-To: <00debaf6e77852efe1dcad4bfda5ebd5bf590ac4.1660050704.git.gitgitgadget@gmail.com>

"Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 11 quoted lines

> +	/*
> +	 * Before fetching from the remote, download and install bundle
> +	 * data from the --bundle-uri option.
> +	 */
> +	if (bundle_uri) {
> +		/* At this point, we need the_repository to match the cloned repo. */
> +		repo_init(the_repository, git_dir, work_tree);
> +		if (fetch_bundle_uri(the_repository, bundle_uri))
> +			warning(_("failed to fetch objects from bundle URI '%s'"),
> +				bundle_uri);
> +	}

I do not offhand know why I suddenly started seeing the issue for this relatively old commit I have had in my tree for at least 10 days, but I am getting this

builtin/clone.c: In function 'cmd_clone':
builtin/clone.c:1248:17: error: ignoring return value of 'repo_init' declared with attribute 'warn_unused_result' [-Werror=unused-result]
 1248 |                 repo_init(the_repository, git_dir, work_tree);
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

with the commit merged in 'seen'.

It seems that the updated ab/submodule-helper-prep is doing it.

Why can't that (or any of Ævar's) topic focus on what it needs to do, without churning the codebase and inflict damages to other topics like this? Quite frustrating.

I'll redo today's integration without the offending topic to give other topics test coverage.