Re: [PATCH v3 4/5] bundle-uri: add support for http(s):// and file://
- From
Derrick Stolee <derrickstolee@github.com>
- Date
- Aug 30, 2022, 13:33 UTC
- Message-ID
- <dcc46c8a-4c49-05d4-db23-0497e08f9fed@github.com>
- In-Reply-To
- <20220829045837.49659-1-tenglong.tl@alibaba-inc.com>
On 8/29/2022 12:58 AM, Teng Long wrote:
Show 14 quoted lines
> Derrick Stolee <derrickstolee@github.com> writes:
>
>> + while (!strbuf_getline(&line, child_out)) {
>> + if (!line.len)
>> + break;
>> + if (!strcmp(line.buf, "get"))
>> + found_get = 1;
>> + }
>
> Clear implementation for me to read, thanks.
>
> I'm not sure but maybe a nit, should it be a "break;" after
> "found_get = 1;" for omitting the left uncencerned capabilities
> to quit earlier?Teng, you are right that it does not hurt to have a 'break' here. Since this topic has already merged, that change will need a forward-fix that I can add to a future series.
Thanks, -Stolee