Re: [PATCH v2 2/3] range-diff: consistently validate the arguments
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 26, 2022, 16:54 UTC
- Message-ID
- <xmqq8rnbymhd.fsf@gitster.g>
- In-Reply-To
- <4cd7f09557c7d0a4802b07d1e8440015e0a50524.1661506770.git.gitgitgadget@gmail.com>
"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 12 quoted lines
> From: Johannes Schindelin <johannes.schindelin@gmx.de> > > This patch lets `range-diff` validate the arguments not only when > invoked with one or two arguments, but also in the code path where three > arguments are handled. > > While at it, we now use `usage_msg_opt*()` consistently. > > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> > --- > builtin/range-diff.c | 41 +++++++++++++++++++++++++++++------------ > 1 file changed, 29 insertions(+), 12 deletions(-)
Very nice. The updated series is worth having if only for this step. Very very pleasing.