Re: [PATCH v2 3/3] range-diff: optionally accept pathspecs

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 26, 2022, 17:02 UTC
Message-ID: <xmqq1qt3ym3p.fsf@gitster.g>
In-Reply-To: <a52ad40e0155caf8285b86ec26bbd47cd2240466.1661506770.git.gitgitgadget@gmail.com>

"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 17 quoted lines

> +	for (i = 0; i < argc; i++)
> +		if (!strcmp(argv[i], "--")) {
> +			dash_dash = i;
> +			break;
> +		}
> +
> +	if (dash_dash == 3 ||
> +	    (dash_dash < 0 && argc > 2 &&
> +	     !get_oid_committish(argv[0], &oid) &&
> +	     !get_oid_committish(argv[1], &oid) &&
> +	     !get_oid_committish(argv[2], &oid))) {
> +		if (dash_dash < 0)
> +			; /* already validated arguments */
> +		else if (get_oid_committish(argv[0], &oid))
>  			usage_msg_optf(_("not a revision: '%s'"),
>  				       builtin_range_diff_usage, options,
>  				       argv[0]);

Very reasonable. We won't ever have "--" on the command line as anything but a dash-dash (i.e. there is no option to the command that can take any string), and thanks to the previous step, this addition falls in place very naturally. Very nicely done.

Will replace. I _think_ this is ready for 'next', but let's see if others spot problems for a few days.

THanks.