Re: t3206-range-diff failures on non x86 arches

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 1, 2023, 21:36 UTC
Message-ID: <xmqq8rggm9x9.fsf@gitster.g>
In-Reply-To: <Y/++KovrW+08XRQc@pobox.com>

Todd Zullinger <tmz@pobox.com> writes:

Show 15 quoted lines

> I wrote:
>> Junio C Hamano wrote:
>>>> On Fedora, rc1 fails most tests in t3206-range-diff.sh on 3
>>>> of the 5 supported architectures: aarch64, ppc64le, and
>>>> s390x.  These tests succeed on i686 and x86_64.  They passed
>>>> on all arches with rc0.
>>> 
>>> Sounds like something d9165bef (range-diff: avoid compiler warning
>>> when char is unsigned, 2023-02-28) may fix.  Can you try merging it
>>> to rc1 yourself and see how the result does?
>> 
>> Oh, indeed it does.  Thanks for the pointer.  I'm running
>> a build with that now.
>
> Confirmed.  That fixes the tests.  Thanks!

Will merge that fix by Réne down to 'master'.

Thanks for promptly reporting the problem and its fix.