Re: t3206-range-diff failures on non x86 arches

From: Todd Zullinger <tmz@pobox.com>
Date: Mar 1, 2023, 20:21 UTC
Message-ID: <Y/+zwrMBvoggqaL5@pobox.com>
In-Reply-To: <xmqqv8jkmea1.fsf@gitster.g>

Junio C Hamano wrote:

Show 15 quoted lines

> Todd Zullinger <tmz@pobox.com> writes:
> 
>> Junio C Hamano wrote:
>>> A release candidate Git v2.40.0-rc1 is now available for testing at
>>> the usual places.  It is comprised of 458 non-merge commits since
>>> v2.39.0, contributed by 78 people, 30 of which are new faces [*].
>>
>> On Fedora, rc1 fails most tests in t3206-range-diff.sh on 3
>> of the 5 supported architectures: aarch64, ppc64le, and
>> s390x.  These tests succeed on i686 and x86_64.  They passed
>> on all arches with rc0.
> 
> Sounds like something d9165bef (range-diff: avoid compiler warning
> when char is unsigned, 2023-02-28) may fix.  Can you try merging it
> to rc1 yourself and see how the result does?

Oh, indeed it does. Thanks for the pointer. I'm running a build with that now.

Sorry for incorrectly suggesting your patch series Peff. I should have looked closer. :)

-- 
Todd