git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] t3404-rebase-interactive.sh: fix typos in title of a rewording test

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 13, 2023, 00:25 UTC
Message-ID
<xmqq8r9aly15.fsf@gitster.g>
In-Reply-To
<76c36744-b821-450b-9817-e0cd8811de65@gmail.com>
Phillip Wood <phillip.wood123@gmail.com> writes:
Show 20 quoted lines
> On 12/09/2023 11:42, Oswald Buddenhagen wrote:
>> This test was introduced by commit 0c164ae7a ("rebase -i: add another
>> reword test", 2021-08-20). I didn't quite get what it was meant to do,
>> so here's an explanation from Phillip:
>> The purpose of the test is to ensure that
>>    (i) There are no uncommited changes when the editor runs. I.e.,
>> we
>>        commit without running the editor and then reword by amending
>>        that commit. This ensures that we have the same user experience
>>        whether or not the commit was fast-forwarded [1].
>>   (ii) That the todo list is re-read after the commit has been
>> reworded.
>>        This is to allow the user to update the todo list while the rebase
>>        is paused for editing the commit message.
>> [1] https://lore.kernel.org/git/20190812175046.GM20404@szeder.dev/
>> Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
>
> This looks good to me, Thanks
>
> Phillip
Thanks, both.  Will queue.
Previous: Phillip Wood
Message 7 of 7 in “t3404-rebase-interactive.sh: fix name of a rewording test”
  1. t3404-rebase-interactive.sh: fix name of a rewording testOswald Buddenhagen, Sep 11, 2023
  2. Junio C HamanoSep 11, 2023
  3. Phillip WoodSep 12, 2023
  4. t3404-rebase-interactive.sh: fix typos in title of a rewording testOswald Buddenhagen, Sep 12, 2023
  5. Oswald BuddenhagenSep 12, 2023
  6. Phillip WoodSep 12, 2023
  7. Junio C HamanoSep 13, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.