From: Junio C Hamano Date: Wed, 13 Sep 2023 00:25:26 GMT Subject: Re: [PATCH v2] t3404-rebase-interactive.sh: fix typos in title of a rewording test Message-ID: In-Reply-To: <76c36744-b821-450b-9817-e0cd8811de65@gmail.com> Phillip Wood writes: > On 12/09/2023 11:42, Oswald Buddenhagen wrote: >> This test was introduced by commit 0c164ae7a ("rebase -i: add another >> reword test", 2021-08-20). I didn't quite get what it was meant to do, >> so here's an explanation from Phillip: >> The purpose of the test is to ensure that >> (i) There are no uncommited changes when the editor runs. I.e., >> we >> commit without running the editor and then reword by amending >> that commit. This ensures that we have the same user experience >> whether or not the commit was fast-forwarded [1]. >> (ii) That the todo list is re-read after the commit has been >> reworded. >> This is to allow the user to update the todo list while the rebase >> is paused for editing the commit message. >> [1] https://lore.kernel.org/git/20190812175046.GM20404@szeder.dev/ >> Signed-off-by: Oswald Buddenhagen > > This looks good to me, Thanks > > Phillip Thanks, both. Will queue.