Re: commit-graph paranoia performance, was Re: [ANNOUNCE] Git v2.43.0-rc1

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 13, 2023, 23:50 UTC
Message-ID: <xmqq8r7143i9.fsf@gitster.g>
In-Reply-To: <20231113205538.GA2028092@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 7 quoted lines

> Should we default GIT_COMMIT_GRAPH_PARANOIA to "0"? Yes, some operations
> might miss a breakage, but that is true of so much of Git. For day to
> day commands we generally assume that the repository is not corrupted,
> and avoid looking at any data we can. Other commands (like "commit-graph
> verify", but maybe others) would probably want to be more careful
> (either by checking this case explicitly, or by enabling the paranoia
> flag themselves).

I am obviously fine with that direction, as that was exactly the stance I took when we discussed the topic on "rev-list --missing" ;-)

Patrick?  Karthik?