git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: commit-graph paranoia performance, was Re: [ANNOUNCE] Git v2.43.0-rc1

From
Jeff King <peff@peff.net>
Date
Nov 14, 2023, 09:05 UTC
Message-ID
<20231114090506.GA2107135@coredump.intra.peff.net>
In-Reply-To
<ZVMz4iDWfC__H8Jp@tanuki>
On Tue, Nov 14, 2023 at 09:46:26AM +0100, Patrick Steinhardt wrote:
Show 13 quoted lines
> > Should we default GIT_COMMIT_GRAPH_PARANOIA to "0"? Yes, some operations
> > might miss a breakage, but that is true of so much of Git. For day to
> > day commands we generally assume that the repository is not corrupted,
> > and avoid looking at any data we can. Other commands (like "commit-graph
> > verify", but maybe others) would probably want to be more careful
> > (either by checking this case explicitly, or by enabling the paranoia
> > flag themselves).
> 
> I'd be fine with that as a follow-up change, yes. I agree that in
> general we shouldn't see this kind of corruption, and it's good that the
> behaviour can be toggled so easily now.
> 
> I'm happy to write that patch if you don't plan to.
I hadn't started on it, so please feel free to go ahead.
-Peff
Previous: Patrick Steinhardt
Message 6 of 6 in “[ANNOUNCE] Git v2.43.0-rc1”
  1. Junio C HamanoNov 8, 2023
  2. Andy KoppeNov 10, 2023
  3. commit-graph paranoia performance, was Re: [ANNOUNCE] Git v2.43.0-rc1Jeff King, Nov 13, 2023
  4. Junio C HamanoNov 13, 2023
  5. Patrick SteinhardtNov 14, 2023
  6. Jeff KingNov 14, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.