Re: commit-graph paranoia performance, was Re: [ANNOUNCE] Git v2.43.0-rc1
On Tue, Nov 14, 2023 at 09:46:26AM +0100, Patrick Steinhardt wrote:
Show 13 quoted lines
> > Should we default GIT_COMMIT_GRAPH_PARANOIA to "0"? Yes, some operations
> > might miss a breakage, but that is true of so much of Git. For day to
> > day commands we generally assume that the repository is not corrupted,
> > and avoid looking at any data we can. Other commands (like "commit-graph
> > verify", but maybe others) would probably want to be more careful
> > (either by checking this case explicitly, or by enabling the paranoia
> > flag themselves).
>
> I'd be fine with that as a follow-up change, yes. I agree that in
> general we shouldn't see this kind of corruption, and it's good that the
> behaviour can be toggled so easily now.
>
> I'm happy to write that patch if you don't plan to.
I hadn't started on it, so please feel free to go ahead.
-Peff