Re: [PATCH v2 4/5] Always check `parse_tree*()`'s return value

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 22, 2024, 17:05 UTC
Message-ID: <xmqq8r3ch1jt.fsf@gitster.g>
In-Reply-To: <dbde46bc-501e-8433-0b8d-b83d0ca9e759@gmx.de>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 7 quoted lines

>> If you happen to reroll for some reason, perhaps: s/Always/always/
>
> Unless I am missing something we only ask the part of a oneline after an
> initial "<something>:" to be downcased.
>
> At least all the "Merge branch [...]" commits are still capitalized and
> nobody complains ;-)

Of course. Merge commits and single-parent commits are very different.

I suspect that the lack of "<area>:" was what triggered the comment, but this being more about the callers all over the place in the code, it may be hard to say what "area" this belongs to. If I were pressed to choose:

    Subject: parse_tree*(): make callers always check return value

would probably be what I would choose, but I usually opt for going the lazy way of not labelling the area at all ;-).