Re: [PATCH v4 2/5] t1517: test commands that are designed to be run outside repository

From: Junio C Hamano <gitster@pobox.com>
Date: May 15, 2024, 15:40 UTC
Message-ID: <xmqq8r0b13t5.fsf@gitster.g>
In-Reply-To: <ZkTFvVihZAY184Gm@tanuki>

Patrick Steinhardt <ps@pks.im> writes:

Show 8 quoted lines

>> The tests that are spread across many scripts make it harder to see if
>> we have enough coverage for the out-of-repository operations,
>
> Put this way I in fact agree with you.
>
>> and the use of "nongit" helper does not change the equation, does it?
>
> No, it doesn't really.

Of course the other side of the coin is that having all tests about a single command (say, "git mailmap") in the same script for both in-repo and out-of-repo operations is also handy in a different way.

I haven't found a good way to balance the two. Obviously duplicating the same test in two scripts (one collection for the same command, the other collection out-of repo operation of various commands) is something I really do want to avoid, so...