Re: [PATCH v5 1/5] setup: add an escape hatch for "no more default hash algorithm" change

From: Patrick Steinhardt <ps@pks.im>
Date: May 21, 2024, 07:57 UTC
Message-ID: <ZkxUBebjx8WvyJnm@tanuki>
In-Reply-To: <20240520231434.1816979-2-gitster@pobox.com>

On Mon, May 20, 2024 at 04:14:30PM -0700, Junio C Hamano wrote:

Show 9 quoted lines

> Partially revert c8aed5e8 (repository: stop setting SHA1 as the
> default object hash, 2024-05-07), to keep end-user systems still
> broken when we have gap in our test coverage but yet give them an
> escape hatch to set the GIT_TEST_DEFAULT_HASH_ALGO environment
> variable to "sha1" in order to revert to the previous behaviour.
> 
> Due to the way the end-user facing GIT_DEFAULT_HASH environment
> variable is used in our test suite, we unfortunately cannot reuse it
> for this purpose.

Okay, so this now really only is an escape hatch for users as we do not specify it in our tests anymore. It does make me wonder whether we want to name the envvar accordingly, but don't mind it much either way. It is only intended to be a stop gap solution anyway that we can eventually drop once we are sufficiently sure that there is no further breakage.

Patrick