git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] gitweb: rss/atom change published/updated date to committer date

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 6, 2024, 22:01 UTC
Message-ID
<xmqq8qyenpsz.fsf@gitster.g>
In-Reply-To
<CALRJROB7gGWok-YPGTjPe+TXkU5Y_MhqcPSiCGoPDzJ=WGHoKA@mail.gmail.com>
Ariel Cabello Mateos <080ariel@gmail.com> writes:
Show 12 quoted lines
> Currently the value used is the author date. Change it to the
> committer date that betters reflect the "published/updated" definition
> and makes rss/atom feeds more linear. Gitlab/Github rss/atom feeds use
> the committer date.
>
> The committer date is already used to determine if more items should be fetched.
>
> Signed-off-by: Jesús Ariel Cabello Mateos <080ariel@gmail.com>
> ---
> Changes since v1:
> - Typo fix in the commit message.
> - Semantic fixes in the commit message.
error: corrupt patch at line 20
Show 15 quoted lines
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index ccd14e0e30..0ef5707557 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -8329,7 +8329,7 @@ sub git_feed {
>                 if (($i >= 20) && ((time - $co{'author_epoch'}) > 48*60*60)) {
>                         last;
>                 }
> -               my %cd = parse_date($co{'author_epoch'}
> , $co{'author_tz'});
> +               my %cd = parse_date($co{'committer_epoch'},
> $co{'committer_tz'});
>
>                 # get list of changed files
>                 open my $fd, "-|", git_cmd(), "diff-tree", '-r', @diff_opts,
Previous: Ariel Cabello MateosNext: Junio C Hamano
Message 4 of 7 in “gitweb: rss/atom change published/updated date to committed date”
  1. gitweb: rss/atom change published/updated date to committed dateJesús Ariel Cabello Mateos, Jul 4, 2024
  2. Junio C HamanoJul 6, 2024
  3. gitweb: rss/atom change published/updated date to committer dateAriel Cabello Mateos, Jul 6, 2024
  4. Junio C HamanoJul 6, 2024
  5. Junio C HamanoJul 6, 2024
  6. gitweb: rss/atom change published/updated date to committer dateJesús Ariel Cabello Mateos, Jul 7, 2024
  7. Junio C HamanoJul 8, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.