Re: [PATCH] gitweb: rss/atom change published/updated date to committed date

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 6, 2024, 06:08 UTC
Message-ID: <xmqq7cdz3vdx.fsf@gitster.g>
In-Reply-To: <20240704164547.94341-1-080ariel@gmail.com>

Jesús Ariel Cabello Mateos <080ariel@gmail.com> writes:

Show 8 quoted lines

> Currently the published(in rss) and the updated(in atom) date
> used is the authored date. Change it to the committed date 
> that betters reflect the "published/updated" definition and 
> makes rss/atom feeds more lineal. Gitlab/Github rss/atom feeds 
> use the commited date.
>
> The committed date is already used to determine if more items
> should be fetched.

Even though "authored" and "committed" date may be grammatically correct if you use "to author" and "to commit" as verbs, the name we use for these two timestamps are "author date" and "committer date" (in other words, "author" and "committer" are not used as verbs but as nouns for possibly two distinct people). So

 * "committed date" (on the title and elsewhere) and "commited date"
   -> "committer date".

 * "authored date" -> "author date".

 * "lineal" -> "linear"?

But your reasoning is absolutely correct about the concept of "publish" more closely corresponds to the committer date than the author date, and the change looks sensible.

Show 18 quoted lines

> Signed-off-by: Jesús Ariel Cabello Mateos <080ariel@gmail.com>
> ---
>  gitweb/gitweb.perl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index ccd14e0e30..0ef5707557 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -8329,7 +8329,7 @@ sub git_feed {
>  		if (($i >= 20) && ((time - $co{'author_epoch'}) > 48*60*60)) {
>  			last;
>  		}
> -		my %cd = parse_date($co{'author_epoch'}, $co{'author_tz'});
> +		my %cd = parse_date($co{'committer_epoch'}, $co{'committer_tz'});
>  
>  		# get list of changed files
>  		open my $fd, "-|", git_cmd(), "diff-tree", '-r', @diff_opts,