git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] object-file: use `container_of()` to convert from base types

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 22, 2026, 20:36 UTC
Message-ID
<xmqq8qckqzw3.fsf@gitster.g>
In-Reply-To
<20260222094158.GA1319383@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 19 quoted lines
> On Sat, Feb 21, 2026 at 11:07:08PM -0800, Junio C Hamano wrote:
>
>> Perhaps a fix-up patch on top of the topic branch like this?
>> 
>> ----- >8 -----
>> Subject: [PATCH] object-file.c: avoid container_of() of a NULL container
>> [...]
>>  static void prepare_loose_object_transaction(struct odb_transaction *base)
>>  {
>> -	struct odb_transaction_files *transaction =
>> -		container_of(base, struct odb_transaction_files, base);
>> +	struct odb_transaction_files *transaction = NULL;
>> +
>> +	if (base)
>> +		transaction =
>> +			container_of(base, struct odb_transaction_files, base);
>
> That works, but you can also use container_of_or_null() in the
> initializer. IMHO the result is easier to read.
Thanks.  Will use that.
Previous: Justin ToblerNext: Junio C Hamano
Message 7 of 8 in “object-file: use `container_of()` to convert from base types”
  1. object-file: use `container_of()` to convert from base typesJustin Tobler, Feb 18, 2026
  2. Patrick SteinhardtFeb 19, 2026
  3. Toon ClaesFeb 20, 2026
  4. Junio C HamanoFeb 22, 2026
  5. Jeff KingFeb 22, 2026
  6. Justin ToblerFeb 22, 2026
  7. Junio C HamanoFeb 22, 2026
  8. object-file.c: avoid container_of() of a NULL containerJunio C Hamano, Feb 22, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.