git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] object-file: use `container_of()` to convert from base types

From
Patrick Steinhardt <ps@pks.im>
Date
Feb 19, 2026, 13:43 UTC
Message-ID
<aZcTcgKDg6N4QW3j@pks.im>
In-Reply-To
<20260218210120.1146078-1-jltobler@gmail.com>
On Wed, Feb 18, 2026 at 03:01:20PM -0600, Justin Tobler wrote:
> To improve code hygiene, replace direct casts from `struct
> odb_transaction` and `struct odb_read_stream` to their concrete
> implementations with `container_of()`.

Right. The reason we want to do this is so that we become independent of the order in which members in `struct odb_read_stream` are declared.

The changes all look good to me, thanks!
Patrick
Previous: Justin ToblerNext: Toon Claes
Message 2 of 8 in “object-file: use `container_of()` to convert from base types”
  1. object-file: use `container_of()` to convert from base typesJustin Tobler, Feb 18, 2026
  2. Patrick SteinhardtFeb 19, 2026
  3. Toon ClaesFeb 20, 2026
  4. Junio C HamanoFeb 22, 2026
  5. Jeff KingFeb 22, 2026
  6. Justin ToblerFeb 22, 2026
  7. Junio C HamanoFeb 22, 2026
  8. object-file.c: avoid container_of() of a NULL containerJunio C Hamano, Feb 22, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.