Re: [PATCH v4 4/6] xdiff/xdl_cleanup_records: make limits more clear
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 31, 2026, 16:13 UTC
- Message-ID
- <xmqq8qb82czd.fsf@gitster.g>
- In-Reply-To
- <32c34d0d-9358-43e3-9d58-5999b3ffd6c2@gmail.com>
Phillip Wood <phillip.wood123@gmail.com> writes:
Show 7 quoted lines
>> + } else {
>> + mlim1 = XDL_MIN(xdl_bogosqrt(xdf1->nrec), XDL_MAX_EQLIMIT);
>> + mlim2 = XDL_MIN(xdl_bogosqrt(xdf2->nrec), XDL_MAX_EQLIMIT);
>
> As Junio has pointed out we now evaluate xdl_bogosqrt() twice which is
> unfortunate. It would have been nice to mention that in the commit
> message and explain why it does not matter.Yup, that completely slipped my mind. Personally I too find the original perfectly readable, but the updated one is not too bad, either.
Thanks.