git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] index-pack, unpack-objects: increase input buffer from 4 KiB to 128 KiB

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 28, 2026, 01:47 UTC
Message-ID
<xmqq8qa726w9.fsf@gitster.g>
In-Reply-To
<469a26e8-4309-4221-abac-e9a09e3f743d@gmail.com>
Derrick Stolee <stolee@gmail.com> writes:
Show 25 quoted lines
> On 4/27/2026 3:26 PM, Scott Bauersfeld via GitGitGadget wrote:
>> From: Scott Bauersfeld <sbauersfeld@g.ucla.edu>
>
>>     Changes since v2
>>     ================
>>     
>>      * Renamed DEFAULT_PACKFILE_BUFFER_SIZE → DEFAULT_IO_BUFFER_SIZE per
>>        Stolee's feedback. The constant is not packfile-specific, since it is
>>        also used by the hashfile layer.
>>      * Stolee noted that WRITE_BUFFER_SIZE in read-cache.c could be
>>        consolidated. That constant was already removed in f6e2cd0625
>>        ("read-cache: delete unused hashing methods", 2021-05-18) when
>>        read-cache.c was converted to use the hashfile API, so there is
>>        nothing left to unify. The rename to DEFAULT_IO_BUFFER_SIZE helps
>>        account for the multiple usages of this constant.
>
> Thank you for discovering this context which made my recommendation
> non-actionable. I was looking at the commit that added the 128K limit,
> which had that in its context, but not at the latest code. My mistake!
>
> I'm very happy with this version and look forward to the performance
> benefits!
>
> Thanks,
> -Stolee
Yes, this version was very pleasant to read.  Thanks both.
Previous: Derrick StoleeNext: Scott Bauersfeld via GitGitGadget
Message 10 of 12 in “index-pack, unpack-objects: increase input buffer from 4 KiB to 128 KiB”
  1. index-pack, unpack-objects: increase input buffer from 4 KiB to 128 KiBScott Bauersfeld via GitGitGadget, Apr 24, 2026
  2. Junio C HamanoApr 25, 2026
  3. Derrick StoleeApr 27, 2026
  4. Junio C HamanoApr 28, 2026
  5. Jeff KingApr 28, 2026
  6. index-pack, unpack-objects: increase input buffer from 4 KiB to 128 KiBScott Bauersfeld via GitGitGadget, Apr 27, 2026
  7. Derrick StoleeApr 27, 2026
  8. index-pack, unpack-objects: increase input buffer from 4 KiB to 128 KiBScott Bauersfeld via GitGitGadget, Apr 27, 2026
  9. Derrick StoleeApr 27, 2026
  10. Junio C HamanoApr 28, 2026
  11. index-pack, unpack-objects: increase input buffer from 4 KiB to 128 KiBScott Bauersfeld via GitGitGadget, Apr 28, 2026
  12. Junio C HamanoMay 12, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.