From: Junio C Hamano Date: Tue, 28 Apr 2026 01:47:02 GMT Subject: Re: [PATCH v3] index-pack, unpack-objects: increase input buffer from 4 KiB to 128 KiB Message-ID: In-Reply-To: <469a26e8-4309-4221-abac-e9a09e3f743d@gmail.com> Derrick Stolee writes: > On 4/27/2026 3:26 PM, Scott Bauersfeld via GitGitGadget wrote: >> From: Scott Bauersfeld > >> Changes since v2 >> ================ >> >> * Renamed DEFAULT_PACKFILE_BUFFER_SIZE → DEFAULT_IO_BUFFER_SIZE per >> Stolee's feedback. The constant is not packfile-specific, since it is >> also used by the hashfile layer. >> * Stolee noted that WRITE_BUFFER_SIZE in read-cache.c could be >> consolidated. That constant was already removed in f6e2cd0625 >> ("read-cache: delete unused hashing methods", 2021-05-18) when >> read-cache.c was converted to use the hashfile API, so there is >> nothing left to unify. The rename to DEFAULT_IO_BUFFER_SIZE helps >> account for the multiple usages of this constant. > > Thank you for discovering this context which made my recommendation > non-actionable. I was looking at the commit that added the 128K limit, > which had that in its context, but not at the latest code. My mistake! > > I'm very happy with this version and look forward to the performance > benefits! > > Thanks, > -Stolee Yes, this version was very pleasant to read. Thanks both.