git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] ls-tree: do not quote %(path) with -z

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 19, 2026, 01:24 UTC
Message-ID
<xmqq8q2p1ulh.fsf@gitster.g>
In-Reply-To
<CAJeEYUaJt49oz+Fq7qwWGyB9p=Hibdzd3113FBhbK1RDn3oHug@mail.gmail.com>
Noam Cohen <noam@noam.me> writes:
> We could avoid the filesystem and synthesize the tree with "git
> mktree" instead, which is what I had at first, but that made the
> test noticeably more complicated than a test_commit in the setup.

Yeah, that, with forced core.quotePath setting, was what I had in mind.

But it is not a requirement to avoid stepping outside US-ASCII while writing tests. It is much better to have tests that use bytes from outside US-ASCII than not having at all. It is just that it would be nicer if we do not have to worry about platform anomalies that cannot store characters outside US-ASCII range.

Previous: Noam CohenNext: Noam Cohen via B4 Relay
Message 4 of 6 in “ls-tree: do not quote %(path) with -z”
  1. ls-tree: do not quote %(path) with -zNoam Cohen via B4 Relay, Nov 18, 2026
  2. Junio C HamanoNov 18, 2026
  3. Noam CohenNov 18, 2026
  4. Junio C HamanoNov 19, 2026
  5. ls-tree: do not quote %(path) with -zNoam Cohen via B4 Relay, Nov 19, 2026
  6. Junio C HamanoNov 19, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.