git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] ls-tree: do not quote %(path) with -z

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 19, 2026, 16:12 UTC
Message-ID
<xmqq4idc2422.fsf@gitster.g>
In-Reply-To
<20261119-ls-tree-format-z-verbatim-path-v2-1-c014e4e4c96f@noam.me>
Noam Cohen via B4 Relay <devnull+noam.noam.me@kernel.org> writes:
Show 25 quoted lines
> From: Noam Cohen <noam@noam.me>
>
> With -z, "git ls-tree" is documented to output the filename verbatim,
> but since 455923e0a1 (ls-tree: introduce "--format" option,
> 2022-03-23) the %(path) placeholder of a custom --format is always
> C-quoted.
>
> Output it verbatim when -z is given, like "git ls-files --format"
> already does.
> ...
> -			quote_c_style(name, &sb, NULL, 0);
> +			if (options->null_termination)
> +				strbuf_addstr(&sb, name);
> +			else
> +				quote_c_style(name, &sb, NULL, 0);
>  			strbuf_setlen(base, baselen);
> ...
> +test_expect_success 'ls-tree --format with -z does not quote paths' '
> +	blob=$(git rev-parse HEAD:top-file.t) &&
> +	tree=$(printf "100644 blob $blob\tdouble\"quote\n" | git mktree) &&
> +	printf "blob double\"quote\0" >expect &&
> +	git -c core.quotePath=true ls-tree -z \
> +		--format="%(objecttype) %(path)" $tree >actual &&
> +	test_cmp expect actual
> +'

Everything looks as expected. Nicely done. Will queue. Thanks.

Previous: Noam Cohen via B4 Relay
Message 6 of 6 in “ls-tree: do not quote %(path) with -z”
  1. ls-tree: do not quote %(path) with -zNoam Cohen via B4 Relay, Nov 18, 2026
  2. Junio C HamanoNov 18, 2026
  3. Noam CohenNov 18, 2026
  4. Junio C HamanoNov 19, 2026
  5. ls-tree: do not quote %(path) with -zNoam Cohen via B4 Relay, Nov 19, 2026
  6. Junio C HamanoNov 19, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.