git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 04/14] appp.sh: use the $( ... ) construct for command substitution

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 28, 2014, 19:20 UTC
Message-ID
<xmqq7g69qn14.fsf@gitster.dls.corp.google.com>
In-Reply-To
<vpqmwf572fx.fsf@anie.imag.fr>
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
Show 22 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
>
>> "brian m. carlson" <sandals@crustytoothpaste.net> writes:
>>
>>>>  CCS=`echo -e "$CMT_MSG\n$HEADERS" | sed -n -e 's/^Cc: \(.*\)$/\1,/gp' \
>>>>  	-e 's/^Signed-off-by: \(.*\)/\1,/gp'`
>>>
>>> It looks like you may have missed a usage here due to the line break.
>>
>> Good eyes ;-)
>>
>> The following may be an obvious replacement patch, but alternatively
>> we could just drop the whole thing (contrib/ material is not
>> something we would need to police strictly for the style---nobody
>> should be mimicking their styles as they are not part of _our_
>> codebase in the first place).
>
> My vote goes for keeping the patch as it is, so that future people
> grepping for `...` construct do not find any after the series is
> finished.
>
> (and because it's simple to do)
Sure, let's do that.
Previous: Matthieu MoyNext: Elia Pinto
Message 8 of 20 in “t9365-continuing-queries.sh: use the $( ... ) construct for command substitution”
  1. 01/14 t9365-continuing-queries.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 23, 2014
  2. 02/14 test-gitmw-lib.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 23, 2014
  3. 03/14 t7900-subtree.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 23, 2014
  4. 04/14 appp.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 23, 2014
  5. brian m. carlsonApr 25, 2014
  6. Junio C HamanoApr 28, 2014
  7. Matthieu MoyApr 28, 2014
  8. Junio C HamanoApr 28, 2014
  9. 05/14 txt-to-pot.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 23, 2014
  10. Matthieu MoyApr 23, 2014
  11. 06/14 git-pull.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 23, 2014
  12. 07/14 git-rebase--merge.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 23, 2014
  13. 08/14 git-rebase.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 23, 2014
  14. 09/14 git-stash.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 23, 2014
  15. 10/14 git-web--browse.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 23, 2014
  16. 11/14 lib-credential.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 23, 2014
  17. 12/14 lib-cvs.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 23, 2014
  18. 13/14 lib-gpg.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 23, 2014
  19. 14/14 p5302-pack-index.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 23, 2014
  20. Matthieu MoyApr 23, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.