git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 14/14] p5302-pack-index.sh: use the $( ... ) construct for command substitution

From
Elia Pinto <gitter.spiros@gmail.com>
Date
Apr 23, 2014, 13:44 UTC
Message-ID
<1398260646-2660-14-git-send-email-gitter.spiros@gmail.com>
In-Reply-To
<1398260646-2660-1-git-send-email-gitter.spiros@gmail.com>

The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`.

The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character.

The patch was generated by:
for _f in $(find . -name "*.sh")
do
   sed -i 's@`\(.*\)`@$(\1)@g' ${_f}
done
and then carefully proof-read.
Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
---
 t/perf/p5302-pack-index.sh |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/perf/p5302-pack-index.sh b/t/perf/p5302-pack-index.sh
index 6cb5b0d..5ee9211 100755
--- a/t/perf/p5302-pack-index.sh
+++ b/t/perf/p5302-pack-index.sh
@@ -8,7 +8,7 @@ test_perf_large_repo
 
 test_expect_success 'repack' '
 	git repack -ad &&
-	PACK=`ls .git/objects/pack/*.pack | head -n1` &&
+	PACK=$(ls .git/objects/pack/*.pack | head -n1) &&
 	test -f "$PACK" &&
 	export PACK
 '
-- 
1.7.10.4
Previous: Elia PintoNext: Matthieu Moy
Message 19 of 20 in “t9365-continuing-queries.sh: use the $( ... ) construct for command substitution”
  1. 01/14 t9365-continuing-queries.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 23, 2014
  2. 02/14 test-gitmw-lib.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 23, 2014
  3. 03/14 t7900-subtree.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 23, 2014
  4. 04/14 appp.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 23, 2014
  5. brian m. carlsonApr 25, 2014
  6. Junio C HamanoApr 28, 2014
  7. Matthieu MoyApr 28, 2014
  8. Junio C HamanoApr 28, 2014
  9. 05/14 txt-to-pot.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 23, 2014
  10. Matthieu MoyApr 23, 2014
  11. 06/14 git-pull.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 23, 2014
  12. 07/14 git-rebase--merge.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 23, 2014
  13. 08/14 git-rebase.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 23, 2014
  14. 09/14 git-stash.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 23, 2014
  15. 10/14 git-web--browse.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 23, 2014
  16. 11/14 lib-credential.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 23, 2014
  17. 12/14 lib-cvs.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 23, 2014
  18. 13/14 lib-gpg.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 23, 2014
  19. 14/14 p5302-pack-index.sh: use the $( ... ) construct for command substitutionElia Pinto, Apr 23, 2014
  20. Matthieu MoyApr 23, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.