Re: [PATCH] bash completion: allow git stash store options completion
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 13, 2015, 18:40 UTC
- Message-ID
- <xmqq7fwqed7b.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <1421171612-12058-1-git-send-email-kuleshovmail@gmail.com>
Alexander Kuleshov <kuleshovmail@gmail.com> writes:
Show 5 quoted lines
> This patch adds bash completion for git stash 'store' subcommand > which apperead at bd514cad (stash: introduce 'git stash store', 18 Jun 2013) > > Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com> > ---
Hmph. The "create" and "store" subcommands are not end-user facing; they are meant to be used in scripts. I am not sure if we want to complete them in the first place. I know "create" already is in the list of completion candidates, but I wonder if adding "store" is making things worse.
I dunno.
Show 26 quoted lines
> contrib/completion/git-completion.bash | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index c21190d..7578266 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -2375,7 +2375,7 @@ _git_show_branch ()
> _git_stash ()
> {
> local save_opts='--keep-index --no-keep-index --quiet --patch'
> - local subcommands='save list show apply clear drop pop create branch'
> + local subcommands='save list show apply clear drop pop create branch store'
> local subcommand="$(__git_find_on_cmdline "$subcommands")"
> if [ -z "$subcommand" ]; then
> case "$cur" in
> @@ -2402,6 +2402,9 @@ _git_stash ()
> __gitcomp_nl "$(git --git-dir="$(__gitdir)" stash list \
> | sed -n -e 's/:.*//p')"
> ;;
> + store,--*)
> + __gitcomp "--message --quiet"
> + ;;
> *)
> ;;
> esac