Re: [PATCH] bash completion: allow git stash store options completion

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Jan 14, 2015, 19:03 UTC
Message-ID: <20150114190345.GC32115@vauxhall.crustytoothpaste.net>
In-Reply-To: <xmqq7fwqed7b.fsf@gitster.dls.corp.google.com>

On Tue, Jan 13, 2015 at 10:40:40AM -0800, Junio C Hamano wrote:

Show 13 quoted lines

>Alexander Kuleshov <kuleshovmail@gmail.com> writes:
>
>> This patch adds bash completion for git stash 'store' subcommand
>> which apperead at bd514cad (stash: introduce 'git stash store', 18 Jun 2013)
>>
>> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
>> ---
>
>Hmph.  The "create" and "store" subcommands are not end-user facing;
>they are meant to be used in scripts.  I am not sure if we want to
>complete them in the first place.  I know "create" already is in the
>list of completion candidates, but I wonder if adding "store" is
>making things worse.

For what it's worth, I'll often sketch out a script at the command line before putting it in a file (either because I realize I'll need to do the same thing again or I want to share it with others), so I think this might be a useful addition.

-- 
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187