Re: Bug: .gitconfig folder
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 27, 2015, 20:30 UTC
- Message-ID
- <xmqq7frtlq56.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <5565C6A7.60007@gmx.es>
Jorge <griffin@gmx.es> writes:
Show 5 quoted lines
> If you have a folder named ~/.gitconfig instead of a file with that > name, when you try to run some global config editing command it will > fail with a wrong error message: > > "fatal: Out of memory? mmap failed: No such device"
That indeed is a funny error message.
How about this patch?
-- >8 -- We show that message with die_errno(), but the OS is ought to know why mmap(2) failed much better than we do. There is no reason for us to say "Out of memory?" here.
Note that mmap(2) fails with ENODEV when the file you specify is not something that can be mmap'ed, so you still need to know that "No such device" can include cases like having a directory when a regular file is expected, but we can expect that a user who creates a directory to a location where a regular file is expected to be would know what s/he is doing, hopefully ;-)
sha1_file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sha1_file.c b/sha1_file.c index ccc6dac..551a9e9 100644 --- a/sha1_file.c +++ b/sha1_file.c @@ -720,7 +720,7 @@ void *xmmap(void *start, size_t length, release_pack_memory(length); ret = mmap(start, length, prot, flags, fd, offset); if (ret == MAP_FAILED) - die_errno("Out of memory? mmap failed"); + die_errno("mmap failed"); } return ret; }