git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] config.c: fix writing config files on Windows network shares

From
Jeff King <peff@peff.net>
Date
Jun 30, 2015, 16:01 UTC
Message-ID
<20150630160125.GB3953@peff.net>
In-Reply-To
<5592ABBC.60904@web.de>
On Tue, Jun 30, 2015 at 04:46:20PM +0200, Torsten Bögershausen wrote:
Show 8 quoted lines
> The value of fstat() is not checked here:
> (indicated by a compiler warning, that contents_sz may be uninitalized.
> 
>  config.c:
>  int git_config_set_multivar_in_file(
>  //around line 2063 (the only call to fstat())
>  		fstat(in_fd, &st);
>  		contents_sz = xsize_t(st.st_size);

There is a similar case in git_config_rename_section_in_file. It looks like they could both just jump to the error case when fstat() fails.

-Peff
Previous: Torsten BögershausenNext: Johannes Schindelin
Message 12 of 20 in “Bug: .gitconfig folder”
  1. JorgeMay 27, 2015
  2. Junio C HamanoMay 27, 2015
  3. Jeff KingMay 27, 2015
  4. Stefan BellerMay 27, 2015
  5. Jeff KingMay 28, 2015
  6. Junio C HamanoMay 27, 2015
  7. Jeff KingMay 28, 2015
  8. 1/4 read-cache.c: drop PROT_WRITE from mmap of indexJeff King, May 28, 2015
  9. 2/4 config.c: fix mmap leak when writing configJeff King, May 28, 2015
  10. config.c: fix writing config files on Windows network sharesKarsten Blees, Jun 30, 2015
  11. Torsten BögershausenJun 30, 2015
  12. Jeff KingJun 30, 2015
  13. Johannes SchindelinJun 30, 2015
  14. Jeff KingJun 30, 2015
  15. 3/4 config.c: avoid xmmap error messagesJeff King, May 28, 2015
  16. 4/4 config.c: rewrite ENODEV into EISDIR when mmap failsJeff King, May 28, 2015
  17. Junio C HamanoMay 28, 2015
  18. Jeff KingMay 28, 2015
  19. Junio C HamanoMay 28, 2015
  20. Junio C HamanoMay 28, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.