git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] Fix detection of uname failure

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 17, 2015, 21:39 UTC
Message-ID
<xmqq7fpy1n0z.fsf@gitster.dls.corp.google.com>
In-Reply-To
<7cf6757e8e81c2f9e102db24efbedb2a@www.dscho.org>
Johannes Schindelin <johannes.schindelin@gmx.de> writes:
Show 11 quoted lines
> On 2015-07-17 19:09, Charles Bailey wrote:
>> From: Charles Bailey <cbailey32@bloomberg.net>
>> 
>> According to POSIX specification uname must return -1 on failure and a
>> non-negative value on success. Although many implementations do return 0
>> on success it is valid to return any positive value for success.  In
>> particular, Solaris returns 1.
>> 
>> Signed-off-by: Charles Bailey <cbailey32@bloomberg.net>
>
> Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de>

I'd s/Ack/Review/; as the original is not your code but you are well qualified (and have my trust) to judge the change to this codepath ;-)

Thanks.
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 7 of 8 in “Fix detection of uname failure”
  1. Fix detection of uname failureCharles Bailey, Jul 17, 2015
  2. Johannes SchindelinJul 17, 2015
  3. Charles BaileyJul 17, 2015
  4. Junio C HamanoJul 17, 2015
  5. Fix detection of uname failureCharles Bailey, Jul 17, 2015
  6. Johannes SchindelinJul 17, 2015
  7. Junio C HamanoJul 17, 2015
  8. Johannes SchindelinJul 18, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.