Re: [PATCH] Fix detection of uname failure

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 17, 2015, 13:06 UTC
Message-ID: <ef7d56584c3b5d6431f895df1d94eba8@www.dscho.org>
In-Reply-To: <1437135095-6244-1-git-send-email-charles@hashpling.org>

Hi Charles,

On 2015-07-17 14:11, Charles Bailey wrote:

Show 10 quoted lines

> diff --git a/dir.c b/dir.c
> index 8209f8b..52dbfd0 100644
> --- a/dir.c
> +++ b/dir.c
> @@ -1848,7 +1848,7 @@ static const char *get_ident_string(void)
>  
>  	if (sb.len)
>  		return sb.buf;
> -	if (uname(&uts))
> +	if (uname(&uts) == -1)

>From a quick `git grep '== -1'` and another quick `git grep '< 0'` it appears to me that we prefer the latter. Maybe you want to adjust it in the patch, too?

Ciao, Johannes