Re: [PATCH] diff: run arguments through precompose_argv

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 5, 2016, 21:42 UTC
Message-ID: <xmqq7fgb20n4.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <570411A6.6060208@web.de>

Torsten Bögershausen <tboegi@web.de> writes:

Show 13 quoted lines

> On 05.04.16 21:15, Johannes Sixt wrote:
>> Am 05.04.2016 um 19:09 schrieb Junio C Hamano:
>>>> Thanks-to: Torsten Bögershausen <tboegi@web.de>
>> 
>> I sense NFD disease: The combining diaresis should combine with the o, not the g. Here is a correct line to copy-and-paste if you like:
>> 
>> Thanks-to: Torsten Bögershausen <tboegi@web.de>
>> 
>> -- Hannes
>
> Good eyes.
>
> And thanks to Alexander for doing this patch

Yup.  It is funny that I wrote:

    Thanks.  The log message talks about "such a file path", but
    precompose_argv() applies indiscriminately on any command line
    arguments, so things like -G<string> would also get the same
    treatment, which I think is what most users would want.

but "git log --grep=" with your name would not have found the one that would have resulted from the original e-mail message applied.