git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] diff: run arguments through precompose_argv

From
Alexander Rinass <alex@fournova.com>
Date
Apr 4, 2016, 20:38 UTC
Message-ID
<1459802325-22056-1-git-send-email-alex@fournova.com>

I found an issue where file paths containing decomposed unicode chars are not converted to precomposed unicode form when passed to the diff command family.

As a result, no diff is displayed.

With the help of Torsten Bögershausen and Junio C Hamano I came up with the following patch to fix the issue.

Alexander Rinass (1):
  diff: run arguments through precompose_argv
 builtin/diff-files.c         |  1 +
 builtin/diff-index.c         |  1 +
 builtin/diff-tree.c          |  2 ++
 builtin/diff.c               |  1 +
 t/t3910-mac-os-precompose.sh | 42 ++++++++++++++++++++++++++++++++++++++++++
 5 files changed, 47 insertions(+)
-- 
2.7.2
Next: Alexander Rinass
Message 1 of 12 in “diff: run arguments through precompose_argv”
  1. diff: run arguments through precompose_argvAlexander Rinass, Apr 4, 2016
  2. diff: run arguments through precompose_argvAlexander Rinass, Apr 4, 2016
  3. Junio C HamanoApr 5, 2016
  4. Johannes SixtApr 5, 2016
  5. Torsten BögershausenApr 5, 2016
  6. Junio C HamanoApr 5, 2016
  7. Alexander RinassApr 6, 2016
  8. Torsten BögershausenApr 6, 2016
  9. Junio C HamanoApr 6, 2016
  10. Junio C HamanoMay 11, 2016
  11. Alexander RinassMay 12, 2016
  12. Junio C HamanoMay 12, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.