Re: [PATCH 4/6] config: return configset value for current_config_ functions

From: Junio C Hamano <gitster@pobox.com>
Date: May 26, 2016, 16:42 UTC
Message-ID: <xmqq7fegydmf.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CACsJy8Ad=yN6aLkH9B6ujUNUvPT-b+jw+CwJORD5Fh1jYeOUZQ@mail.gmail.com>

Duy Nguyen <pclouds@gmail.com> writes:

Show 13 quoted lines

> On Thu, May 19, 2016 at 7:08 AM, Jeff King <peff@peff.net> wrote:
>> On Wed, May 18, 2016 at 06:43:23PM -0400, Jeff King wrote:
>>
>>>  cache.h                |  1 +
>>>  config.c               | 51 +++++++++++++++++++++++++++++++++++++++++---------
>>>  t/helper/test-config.c | 20 ++++++++++++++++++++
>>>  t/t1308-config-set.sh  | 23 +++++++++++++++++++++++
>>> [...]
>>> +test_expect_success 'iteration shows correct origins' '
>>> +     echo "[alias]test-config = !test-config" >.gitconfig &&
>
> How about using 'which' to get absolute path for test-config and put
> it here? Then we don't rely on $PATH anymore.

Don't use which, which is not portable.

Remind me why we end up running ./test-config instead of ./bin-wrappers/test-config? Should our tests be running bin-wrappers early in their $PATH, perhaps?