Re: [PATCH/RFC 0/6] pack-objects hook for upload-pack

From: Junio C Hamano <gitster@pobox.com>
Date: May 25, 2016, 00:59 UTC
Message-ID: <CAPc5daV6bdUKS-ExHmpT4Ppy2S832NXoyPw7aOLP7fG=WrBPgg@mail.gmail.com>
In-Reply-To: <20160518223712.GA18317@sigill.intra.peff.net>

On Wed, May 18, 2016 at 3:37 PM, Jeff King <peff@peff.net> wrote:

Show 15 quoted lines

> I've often wanted to intercept the call from upload-pack to
> pack-objects. The final patch in this series goes into more detail, but
> basically it's good for:
>
>   1. Capturing the output from pack-objects for debugging/inspection.
>
>   2. Capturing the input to pack-objects to replay for debugging or
>      performance analysis.
>
>   3. Caching pack-objects output.
>
> It's pretty trivial to add a hook to run instead of pack-objects (and
> the hook would just run pack-objects itself). But we don't want to run
> hooks in upload-pack, because we don't necessarily trust the repository
> we're running in.

Although I'd need to study the final step a bit more carefully than I did, overall I think these are good changes. The way the callbacks learn about the origin of the configuration may have to be rethought in the long run, though. We already have been relying on a filename thing kept separately as a global variable, and the approach taken by this series extends it, so we are not making anything fundamentally worse, but at some point we may need to bite the bullet and pass kv-info as an extra callback parameter or something.

Thanks.