git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] grep: fix grepping for "intent to add" files

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 16, 2016, 18:12 UTC
Message-ID
<xmqq7fdp57gg.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20160616065324.GA14967@hashpling.org>
Charles Bailey <charles@hashpling.org> writes:
Show 7 quoted lines
> http://thread.gmane.org/gmane.comp.version-control.git/272363/focus=276358
>
> http://thread.gmane.org/gmane.comp.version-control.git/283001/focus=283002
>
> Unless I've misunderstood the conversation and commit message, the
> referenced commit was supposed to be a "code as a comment" commit with
> no change in observable behavior

Thanks for a pointer; 276358 claims that ce->ce_mode would be zero for path added with "git add -N path", but I do not think it is correct.

The updated behaviour is more understandable. With "add -N", the user said "Just keep an eye on this path, I cannot decide what the contents for this path in the index should be at this moment". grep_cache() that checks the contents in the index cannot say what is in the index, because the contents is not yet there.

Previous: Charles BaileyNext: Duy Nguyen
Message 2 of 8 in “grep: fix grepping for "intent to add" files”
  1. grep: fix grepping for "intent to add" filesCharles Bailey, Jun 16, 2016
  2. Junio C HamanoJun 16, 2016
  3. Duy NguyenJun 16, 2016
  4. Charles BaileyJun 16, 2016
  5. Duy NguyenJun 16, 2016
  6. Charles BaileyJun 16, 2016
  7. Duy NguyenJun 16, 2016
  8. Junio C HamanoJun 16, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.