Re: [PATCH] grep: fix grepping for "intent to add" files
- From
Charles Bailey <charles@hashpling.org>
- Date
- Jun 16, 2016, 11:44 UTC
- Message-ID
- <20160616114452.GA21930@hashpling.org>
- In-Reply-To
- <CACsJy8Bp6Mv2D1QCsR6MWhW2XMedo2svQKHBrx8AgA1Le56Grw@mail.gmail.com>
On Thu, Jun 16, 2016 at 05:57:18PM +0700, Duy Nguyen wrote:
Show 9 quoted lines
> > "git grep --cached" searches file content that will be committed by > "git commit" (no -a). An i-t-a entry will not be committed (you would > need "git add" first, or do "git commit -a"). So if I say "search > among the to-be-committed file content, list files that do not match > abc" (git grep -l -v --cached abc), the i-t-a entry will show up > because its fake content is empty (i.e. not contain "abc"), even > though it's not in the "to-be-committed" list. So yeah, correctness > issue.
OK, I think there is an issue there but it's not with "-l -v --cached" but rather with "-L --cached". If my understanding is correct, "-l -v" means "has a line that doesn't match" whereas "-L" means "has no line that matches".
Does this sound correct? I'll try adding a new test.