Re: [RFC/PATCH 3/3] mailinfo: handle in-body header continuations

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 16, 2016, 23:04 UTC
Message-ID: <xmqq7fabigzf.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <128036e3-47b4-b7ae-034f-8d227a62729f@google.com>

Jonathan Tan <jonathantanmy@google.com> writes:

Show 8 quoted lines

> On 09/16/2016 01:59 PM, Junio C Hamano wrote:
>>         if (mi->in_line_header->len) {
>>                 /* we have read the beginning of one in-line header */
>>                 if (line->len && isspace(*line->buf) &&
>>                     !(mi->use_scissors && is_scissors_line(line))) {
>
> Minor note: this means that the scissors check appears twice in the
> code, once here and once below (for the non-header case).

Yes. I actually was wondering if it is even more sensible to always have the scissors check at the very beginning. Even if we saw a half-written in-body header already in the message, when we see a scissors line, we clear the slate and restart as if the line after the scissors is the first line in the body of the message.

Show 11 quoted lines

>>                         append to mi->in_line_header strbuf;
>>                         return 0;
>>                 }
>>                 /* otherwise we know mi->in_line_header is now complete */
>>                 check_header(mi, mi->in_line_header, ...);
>
> (Sorry - should have also noticed this in your original e-mail.)
>
> I'm concerned about what happens if check_header fails - we would then
> have some lines which need to be treated as log messages. (At least,
> they are currently treated that way.)

I actually think we should refactor check_header() further so that in-body header processing does not even see things that shouldn't be changed. The current check_header() should be used only for real mail headers, and then a reduced version of check_header() that is called for in-body will _ONLY_ handle the header lines that are handled by the first "search for the interesting parts" loop.

And of course we would update your "does it look like rfc2822?" to match what are handled by the "interesting parts" loop. That I think would match the current behaviour much better, I would think.

The ">From " and "[PATCH]" cases in check_header() should not even be there. We should handle them inside handle_commit_msg(), as these two cases should never appear in the real header part of a message.

And if we clean it up like that, I do not think we would ever need to worry about "ah, it looked like a header but it is not after all". And not having to worry about it is a good thing and should be one of the primary goals in this conversion, I whould think.

Thanks.