Re: [RFC 00/14] Allow fetch-pack to send ref names (globs allowed)

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 9, 2017, 00:26 UTC
Message-ID: <xmqq7f50tdja.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170207235350.10718-1-jonathantanmy@google.com>

Jonathan Tan <jonathantanmy@google.com> writes:

Show 6 quoted lines

> Usages of the list of remote refs or the remote-local ref
> map are updated as follows:
>  - check_not_current_branch (which checks that the current branch is not
>    affected by the fetch) is performed both on the original ref map (to
>    die before the fetch if we can, as an optimization) and on the new
>    ref map (since the new ref map is the one actually applied).

OK.

>  - Pruning is done based on the new ref map.

OK. As that is what eventually gets "installed" on the local side, it makes sense to become consistent with that set, not the set the original server gave you.

Show 5 quoted lines

>  - backfill_tags (for tag following) is performed using the original
>    list of remote refs because the new list of fetched refs is not
>    guaranteed to contain tag information. (Since backfill_tags performs
>    another fetch, it does not need to be fully consistent with the
>    just-returned packfile.)

This smells correct but I need to think about this one a bit more.

Overall I think the strategy is agreeable.