[RFC 08/14] fetch-pack: check returned refs for matches
- From
- Jonathan Tan <jonathantanmy@google.com>
- Date
- Jan 25, 2017, 22:03 UTC
- Message-ID
- <b722c0e310305a7eb4013209122db3a0c7b2052c.1485381677.git.jonathantanmy@google.com>
- In-Reply-To
- <cover.1485381677.git.jonathantanmy@google.com>
Instead of setting "matched" on matched refs, detect matches by checking the sought refs against the returned refs. Also, since the "matched" field in struct ref is now no longer used, remove it.
This is the 2nd of 3 patches to eliminate using input refs to communicate information obtained by the fetch mechanism.
(There are possibly ways more efficient than a nested for loop to accomplish this. However, since a subsequent patch will compare the user-provided refspecs against the fetched refs directly, and thus necessitating the nested for loop anyway, I decided to use the nested for loop in this patch.)
Signed-off-by: Jonathan Tan <jonathantanmy@google.com> --- builtin/fetch-pack.c | 7 ++++++- fetch-pack.c | 9 ++++++--- fetch-pack.h | 2 -- remote.h | 3 +-- 4 files changed, 13 insertions(+), 8 deletions(-)
diff --git a/builtin/fetch-pack.c b/builtin/fetch-pack.c index cfe9e447c..f31f874a0 100644 --- a/builtin/fetch-pack.c +++ b/builtin/fetch-pack.c @@ -4,6 +4,7 @@ #include "remote.h" #include "connect.h" #include "sha1-array.h" +#include "refs.h" static const char fetch_pack_usage[] = "git fetch-pack [--all] [--stdin] [--quiet | -q] [--keep | -k] [--thin] " @@ -220,7 +221,11 @@ int cmd_fetch_pack(int argc, const char **argv, const char *prefix) * an error. */ for (i = 0; i < nr_sought; i++) { - if (!sought[i] || sought[i]->matched) + struct ref *r; + for (r = ref; r; r = r->next) + if (!sought[i] || refname_match(sought[i]->name, r->name)) + break; + if (r) continue; error("no such remote ref %s", sought[i]->name); ret = 1; diff --git a/fetch-pack.c b/fetch-pack.c index 9a87ddd3d..d4642b05c 100644 --- a/fetch-pack.c +++ b/fetch-pack.c @@ -562,6 +562,7 @@ static void filter_refs(struct fetch_pack_args *args, struct ref **newtail = &newlist; struct ref *ref, *next; int i; + int *matched = xcalloc(nr_sought, sizeof(*matched)); i = 0; for (ref = *refs; ref; ref = next) { @@ -578,7 +579,7 @@ static void filter_refs(struct fetch_pack_args *args, break; /* definitely do not have it */ else if (cmp == 0) { keep = 1; /* definitely have it */ - sought[i]->matched = 1; + matched[i] = 1; } i++; } @@ -604,19 +605,21 @@ static void filter_refs(struct fetch_pack_args *args, unsigned char sha1[20]; ref = sought[i]; - if (ref->matched) + if (matched[i]) continue; if (get_sha1_hex(ref->name, sha1) || ref->name[40] != '\0' || hashcmp(sha1, ref->old_oid.hash)) continue; - ref->matched = 1; + matched[i] = 1; *newtail = copy_ref(ref); newtail = &(*newtail)->next; } } *refs = newlist; + + free(matched); } static void mark_alternate_complete(const struct ref *ref, void *unused) diff --git a/fetch-pack.h b/fetch-pack.h index c912e3d32..76f7c719c 100644 --- a/fetch-pack.h +++ b/fetch-pack.h @@ -33,8 +33,6 @@ struct fetch_pack_args { /* * sought represents remote references that should be updated from. - * On return, the names that were found on the remote will have been - * marked as such. */ struct ref *fetch_pack(struct fetch_pack_args *args, int fd[], struct child_process *conn, diff --git a/remote.h b/remote.h index 57d059431..2f7f23d47 100644 --- a/remote.h +++ b/remote.h @@ -89,8 +89,7 @@ struct ref { force:1, forced_update:1, expect_old_sha1:1, - deletion:1, - matched:1; + deletion:1; /* * Order is important here, as we write to FETCH_HEAD
-- 2.11.0.483.g087da7b7c-goog